search

UNLV-CS472-672 / 2024-S-GROUP3-Barbell

A workout-tracking app with a support website that does more than just track workouts. Cross platform in IOS and Android
4 stars 0 forks source link

Restyle app #264

Closed mva919 closed 5 months ago

mva919 commented 5 months ago

What type of PR is this? (Check all that apply)

Description

What did you change? How did you change it? Polish and restyle app for demo

Tests

How was this tested?

[Optional] Screenshots

IMG_7551 IMG_7552 image

Documentation

Link to external documentation:

[Optional] AI Usage

[Optional] Are there any post-deployment tasks we need to perform?

mva919 commented 5 months ago

These two components don't have the same width nor do they have the same corner radius:

Screenshot 2024-04-27 at 6 19 29 PM

Also the activity component was ideally just going to be a snapshot of recent friends that have completed a workout. Tapping on the component would redirect to the page with more comprehensive information on the Friend Activity. This is a quick mockup I made on Figma:

Screenshot 2024-04-27 at 6 30 24 PM

You can fix this in this PR, we could make a new issue for refactoring, or we could just change that component altogether and go with your approach.

Also I'm not sure if this is only on my end, but the profile view has a weird section that cuts off at the bottom. I already ran pnpm clean and rebuilt. Could be something on my end though. Check out right near the top of the plus button:

https://github.com/UNLV-CS472-672/2024-S-GROUP3-Barbell/assets/85365584/c9944e69-f2c6-4dad-8cb4-f63f8a8847d3

good catch with the border radius and width i didn't notice 💀

For the friends activity i think that's a good idea, all i did was fix it since elliot made it before my backend change

and the sign out thing is caused by the circle in the bottom nav

thienguen commented 5 months ago

These two components don't have the same width nor do they have the same corner radius: Screenshot 2024-04-27 at 6 19 29 PM Also the activity component was ideally just going to be a snapshot of recent friends that have completed a workout. Tapping on the component would redirect to the page with more comprehensive information on the Friend Activity. This is a quick mockup I made on Figma: Screenshot 2024-04-27 at 6 30 24 PM You can fix this in this PR, we could make a new issue for refactoring, or we could just change that component altogether and go with your approach. Also I'm not sure if this is only on my end, but the profile view has a weird section that cuts off at the bottom. I already ran pnpm clean and rebuilt. Could be something on my end though. Check out right near the top of the plus button:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-27.at.18.25.51.mp4

good catch with the border radius and width i didn't notice 💀

For the friends activity i think that's a good idea, all i did was fix it since elliot made it before my backend change

and the sign out thing is caused by the circle in the bottom nav

at time like this, you can just blame it onto T

mva919 commented 5 months ago

image @taylorfinelli fixed the inconsistencies

thienguen commented 5 months ago

reviewing now

thienguen commented 5 months ago

1. The header be hitting the camera sometimes

image

image

Have some small hiccup w the styling of tailwind, but probably I need to built it...

I dol like the underdevelopment component, pretty neat

taylorfinelli commented 5 months ago

1. The header be hitting the camera sometimes

image

image

Have some small hiccup w the styling of tailwind, but probably I need to built it...

I dol like the underdevelopment component, pretty neat

Yeah rebuild it. I had similar issues too but once I rebuilt they went away.