Closed noodaj closed 5 months ago
Great work @noodaj!
The toast alerts work well on the login page and the profile update page!
One thing I noticed is when the password does not meet all the requirements for logging in, it shows the error message that says it should be such and such. I think we should just have no error message and show that the account isn't found.
The popup alerts look good though! ٩(⊙‿⊙)۶
Why should we not have the error message, we haven't checked if the account did or did not exist yet. That step is to validate both the username and password before we attempt to sign in.
Great work @noodaj! The toast alerts work well on the login page and the profile update page! One thing I noticed is when the password does not meet all the requirements for logging in, it shows the error message that says it should be such and such. I think we should just have no error message and show that the account isn't found. The popup alerts look good though! ٩(⊙‿⊙)۶
Why should we not have the error message, we haven't checked if the account did or did not exist yet. That step is to validate both the username and password before we attempt to sign in.
Sorry should have been more clear. That error message is good! Another message pops up when you type in the password and it doesn't have one capital letter, special character etc. It won't let you sign in if it doesn't meet the password requirements. I think that error message is a must for the registering but logging in not so much.
After discussion, we have decided that the error is ok!
Description / Changes Made
How to Test
Checklist
When reviewing
There are a lot of changed files in this PR. A majority of them are not changed. This was due to the
.prettierrc
file that I added for styling if you already have prettier installed. It will help reduce the amount of changes when doing merge conflicts.