Added bio update/Toast/prettier formatting

UNLV-CS472-672 / 2024-S-GROUP5-Munch

The Munch app is a social platform where users create profiles by selecting preferred foods.

1 stars 11 forks source link

Added bio update/Toast/prettier formatting #59

Closed noodaj closed 5 months ago

noodaj commented 5 months ago

Description / Changes Made

Added Toast messages for updating bio and login fails.
Added function to update user settings in the profile edit.

How to Test

Install packages
Run app on when login, test with some random user/password
When logged in check update first/last name with something

Checklist

[x] I have added/updated relevant documentation, and I have followed the coding style guidelines.
[x] I have added/updated tests, and I have run the test suite and all tests pass.
[x] I have checked for any potential conflicts with other branches and fixed any merge conflicts.

When reviewing

There are a lot of changed files in this PR. A majority of them are not changed. This was due to the .prettierrc file that I added for styling if you already have prettier installed. It will help reduce the amount of changes when doing merge conflicts.

List of ignore files

app.json

eas.json

tsconfig.json

noodaj commented 5 months ago

Great work @noodaj!

The toast alerts work well on the login page and the profile update page!

One thing I noticed is when the password does not meet all the requirements for logging in, it shows the error message that says it should be such and such. I think we should just have no error message and show that the account isn't found.

The popup alerts look good though! ٩(⊙‿⊙)۶

Why should we not have the error message, we haven't checked if the account did or did not exist yet. That step is to validate both the username and password before we attempt to sign in.

mitshelle commented 5 months ago

Great work @noodaj! The toast alerts work well on the login page and the profile update page! One thing I noticed is when the password does not meet all the requirements for logging in, it shows the error message that says it should be such and such. I think we should just have no error message and show that the account isn't found. The popup alerts look good though! ٩(⊙‿⊙)۶

Why should we not have the error message, we haven't checked if the account did or did not exist yet. That step is to validate both the username and password before we attempt to sign in.

Sorry should have been more clear. That error message is good! Another message pops up when you type in the password and it doesn't have one capital letter, special character etc. It won't let you sign in if it doesn't meet the password requirements. I think that error message is a must for the registering but logging in not so much.

mitshelle commented 5 months ago

After discussion, we have decided that the error is ok!