search

UNMCCC / CRIIS_Source_Extracts_for_OMOP

Cancer Clinical Data integration - Set of SQL extractions from disparate health system sources targeting the OMOP data model
MIT License
0 stars 0 forks source link

CNExT - making Visit-Detail PKs unique #170

Closed isangil closed 2 years ago

isangil commented 2 years ago

Let's add the clinical table abbreviations (SRG, HOR, CHM) to the primary Keys of each clinical extract AND the visit detail, we will avoid having false duplicates.

isangil commented 2 years ago

if we can pls committ changes one by one (extract-sql), that way is not a massive review.

lvarnedoe commented 2 years ago

okay. yes, I'll commit one by one. I will add, for example, 'RAD-' + rad.uk to make up the source_pk. I have to do the same to the visit_detail_id - have it be 'RAD-' + rad.uk, or it won't be unique. 'RAD-' + rad.fk2 would still not be unique.

isangil commented 2 years ago

exactly, thanks

lvarnedoe commented 2 years ago

Okay. will do.

isangil commented 2 years ago

need the HospSupp join to finish this one @lvarnedoe thank you