search

UNOMP / unified-node-open-mining-portal

Development stopped and is now unsupported. The node.js version is being deprecated in October 2016.
GNU General Public License v2.0
347 stars 395 forks source link

How to update UNOMP RPC call for altcoin with core v0.17+ #300

Open wes45 opened 5 years ago

wes45 commented 5 years ago

After updating wallet core to v0.17 UNOMP reports this error below concerning getinfo needing to be replaced by getnetworkinfo. Could someone please advice what files to edit to fix this?

Pool Thread 1 Could not start pool, error with init RPC getinfo - {"code":-32601,"message":"getinfo\n\nThis call was removed in version 0.16.0. Use the appropriate fields from:\n- getblockchaininfo: blocks, difficulty, chain\n- getnetworkinfo: version, protocolversion, timeoffset, connections, proxy, relayfee, warnings\n- getwalletinfo: balance, keypoololdest, keypoolsize, paytxfee, unlocked_until, walletversion\n."}

ahmedbodi commented 5 years ago

Help with this can be bought here: https://www.fiverr.com/ahmedbodi/setup-a-cryptocurrency-mining-pool

mooleshacat commented 5 years ago

@ahmedbodi stop spamming issues with spam to make you money. Any idiot with half a brain can set up a pool, and I would do it for less than 50$ forget the 500 or so you charge on fiverr

@wes45 what coin is this for? Can you please post your coins/coinname.json and pool_configs/coinname.json?

========

I will be working on this compatability issue with EASYNOMP but this is a per-coin issue, it affects multiple coins.

Thanks

ahmedbodi commented 5 years ago

I'm welcome to post as i wish. This is far from a per-coin issue. I've fixed this issue in the NOMP Codebase. UNOMP is so far outdated it makes 0 sense to continue working on this codebase. If an idiot with half a brain could setup a pool securely i dont think there would be a repository filled with such issues. You're welcome to do it for whatever price you like. I'm not stopping you. I've been doing this stuff before NOMP even existed. Experience says a lot.

ScriptProdigy commented 5 years ago

Also experiencing this issue, was hoping it was already fixed. Will post my fixes here once complete free of charge.

EDIT: Following https://github.com/zone117x/node-stratum-pool/pull/133/files in node_modules/merged-pooler/ does the trick. No need to charge people for something already public and working.

Teejayare commented 5 years ago

is there a way to support both getnetworkinfo and getinfo for 2 different algos on the 1 pool

ScriptProdigy commented 5 years ago

is there a way to support both getnetworkinfo and getinfo for 2 different algos on the 1 pool

Its sloppy but you could integrate retrying on error of getnetworkinfo with getinfo. Quickest way I can think of, try getnetworkinfo, if there is an error try getinfo and return that

Teejayare commented 5 years ago

I tested the method here... https://github.com/zone117x/node-stratum-pool/tree/master/lib

Looks to have both yet still does not work. Would you have another way / example please?