UO-OACISS / tau2

TAU Performance System Public Mirror (Updated every night at midnight, USA Pacific Time)
http://tau.uoregon.edu
Other
36 stars 15 forks source link

tau_exec interferes with PAPI ROCm component #10

Open gcongiu opened 10 months ago

gcongiu commented 10 months ago

The following line seems problematic when TAU and PAPI are installed through Spack (Spack installed PAPI always uses HSA_TOOLS_LIB to locate librocprofiler64.so):

https://github.com/UO-OACISS/tau2/blob/8bfe9aa8d640a0da9f8750f2a8c67a55249be426/tools/src/tau_exec#L1326:

When I run tau_exec with PAPI + ROCm component support enabled, the component in PAPI is always disabled. This appears to be related to the line above, that sets HSA_TOOLS_LIB="" even though the "-rocm" option is not used.

Perhaps this should be changed to:

$dryrun [ "x$TAU_HSA_TOOLS_LIB" != "x" ] && export HSA_TOOLS_LIB=TAU_HSA_TOOLS_LIB

instead? Perhaps even prevent tau_exec from setting HSA_TOOLS_LIB if already set?