UP-NextPush / android

UnifiedPush provider for Nextcloud - android application - Moved to https://codeberg.org/NextPush/nextpush-android
GNU Affero General Public License v3.0
38 stars 8 forks source link

Notifications when phone offline #100

Open reh9 opened 1 year ago

reh9 commented 1 year ago

Hi,

Sometimes I disable mobile data and wifi on my phone to save battery and reduce radiations. It is obvious there will be no connection.

In such cases NextPush has notifications regarding bad connection which I'd like to avoid. I could disable the notifications but I suspect that by disabling notifications also NextPush behaviour is changed ( not detecting pushes ).

Is there a way to disable notifications but not effect Next Push performance?

p1gp1g commented 1 year ago

Which version of NextPush do you use ? Something regarding this has already be done :/ Could you give a screenshot of the notification ?

reh9 commented 1 year ago

I have the latest version from F-droid: 1.7.1 Now I only caught one message but there are several different messages.

24 Aug 2023 11:10:41 S1m @.***>:

Which version of NextPush do you use ? Something regarding this has already be done :/ Could you give a screenshot of the notification ?

— Reply to this email directly, view it on GitHub[https://github.com/UP-NextPush/android/issues/100#issuecomment-1691307668], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AXWOQWUZNHQLA2QYAA3LKGLXW4LA3ANCNFSM6AAAAAA34UJBJE]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AXWOQWXGPLRC4MUY5XPNVXDXW4LA3A5CNFSM6AAAAAA34UJBJGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEZ5HJI.gif]

p1gp1g commented 1 year ago

Which message it is ? How do you reproduce exactly ? Only enabling plane mode ?

reh9 commented 1 year ago

I see now that mail attachments are not seen. Yes, plane mode produces this effect although I only disable data and wifi but keep the phone signal. Here is the screenshot: Screenshot_2023-08-24-11-58-50-866-edit_com miui home

p1gp1g commented 1 year ago

Ok, I can't easily reproduce, there might be a RACE condition. The last version (1.8.0) improved the checks done to avoid unnecessary service restarts and it may fix this issue in the same time. Could you try with this version ?

reh9 commented 1 year ago

I can't find this version on github or fdroid - can you post a link? Anyway... it is not only about offline mode ( see image below ) - is there a way to disable notifications at all since they don't seem to be valuable for daily use? I know notifications can be disabled in andorid settings - but I guess this also disables some needed functionality or am I mistaken? Is there a way to disable notifications without affecting the core functionality? Screenshot_2023-09-01-11-30-33-568-edit_com miui home

p1gp1g commented 1 year ago

Development is moving to codeberg, you can see the release there : https://codeberg.org/NextPush/nextpush-android/releases

You can disable the notifications in the OS settings, it won't affect the behavior of the app. But the foreground notification is required to get a foreground service. The disconnected notif too, if the server is unreachable (but you can disable it if you want)

Anyway, it would be nice to know if the last version fixes your issue with the airplane mode :)

p1gp1g commented 1 year ago

Is the problem fixed with 1.8.0/1.8.1 ?

reh9 commented 1 year ago

Can't notice any difference but anyway it is not a big deal :) Screenshot_2023-09-10-23-23-22-703-edit_com miui home

p1gp1g commented 1 year ago

Hm that's annoying. It means the connection fails twice before the network callback is notified for the lost network.

Could you :

reh9 commented 1 year ago

Screenshot_2023-09-11-09-12-32-760-edit_org unifiedpush distributor nextpush_