UP-NextPush / server-app

UnifiedPush provider for Nextcloud - server application - Moved to https://codeberg.org/NextPush/uppush
GNU Affero General Public License v3.0
67 stars 8 forks source link

Add checks to the settings page #31

Open MCMic opened 1 year ago

MCMic commented 1 year ago

The settings page gives instructions like redis needs to be used, pm.max_children needs to be high, it would be much more useful if it checked the current configuration and show a valid/invalid status instead.

For Redis, I’m pretty sure the application can check if it is configured and show a green/red message depending on the status?

For pm.max_children, it can show the current value for the setting, and maybe calculate how many users it can serve with the current setting.

For proxy buffering and timeout I do not know if this can be checked easily but if it is then it should be as well.

provokateurin commented 1 year ago

At least timeout would be checkable by just connecting to it from the web interface and measuring the time until the connection is closed. I guess proxy buffering introduces some latency to the requests, but I'm not sure if that is really testable since it could just be a slow internet connection or similar.

p1gp1g commented 1 year ago

Version 1.6.1 of the android app (and 1.6.0 but it there are some bugs) do these checks :)

It checks:

provokateurin commented 1 year ago

Sounds good, but doing it on the server would also be nice.

p1gp1g commented 1 year ago

I agree, but it is less urgent now :)

BTW, if someone wants to contribute, help is welcome