search

UP-NextPush / server-app

UnifiedPush provider for Nextcloud - server application - Moved to https://codeberg.org/NextPush/uppush
GNU Affero General Public License v3.0
67 stars 8 forks source link

Keepalive value is string #35

Closed provokateurin closed 1 year ago

provokateurin commented 1 year ago

https://github.com/UP-NextPush/server-app/blob/ea2264cc05443f295a662030ad13c4a40c744eb9/lib/Controller/UnifiedPushProviderController.php#L101-L106

Why is $keepalive a string? It can just be an integer and the framework will parse it already.

p1gp1g commented 1 year ago

Good catch. Feel free to open a PR :) (Or I'll do it later)

provokateurin commented 1 year ago

Alright, I just wasn't sure if there was a good reason why it is this way.

p1gp1g commented 1 year ago

I've just blindly followed the requests with variables :)