search

UPB-CS-OpenSourceUpstream / tock

A secure embedded operating system for microcontrollers
https://www.tockos.org
Other
2 stars 6 forks source link

Made the set_clocks functions public to crates only #11

Closed JADarius closed 1 year ago

JADarius commented 1 year ago

Pull Request Overview

The set_clocks functions from the RP2040 drivers are defined as public. They should be defined as public only for the crate to be more secure. This pull request addresses that issue.

TODO or Help Wanted

This pull request still needs code review.

Documentation Updated

Formatting

alexandruradovici commented 1 year ago

Please write the upstream PR message.

JADarius commented 1 year ago

I have changed the PR message

alexandruradovici commented 1 year ago

Please send the pull request to Tock and post the link.

JADarius commented 1 year ago

I have submitted a PR: https://github.com/tock/tock/pull/3373

alexandruradovici commented 1 year ago

Please check the ran make prepush box in the upstream pull request.

JADarius commented 1 year ago

Done

alexandruradovici commented 1 year ago

Merged upstream.

alexandruradovici commented 1 year ago

What about trying a more difficult issue, like #6?