search

UPB-CS-OpenSourceUpstream / tock

A secure embedded operating system for microcontrollers
https://www.tockos.org
Other
2 stars 6 forks source link

Refactoring get_peripherals #17

Closed RaresCon closed 1 year ago

RaresCon commented 1 year ago

Pull Request Overview

This pull request refactors all appearances of the get_peripherals() function to create_peripherals(). Issue: https://github.com/tock/tock/issues/3270

Testing Strategy

This pull request was not tested being only refactoring.

TODO or Help Wanted

This pull request still needs feedback / code review.

Documentation Updated

Formatting

alexandruradovici commented 1 year ago

This looks good, please rebase it to the newest master. @RaresCon

RaresCon commented 1 year ago

I'm sorry for replying so late, I had some problems regarding the way of rebasing my fork. So, in short, my repo is forked from the original Tock repo, so I can't really rebase to the newest master of this one. I tried some dark magic in the past days, but couldn't remove the commits coming from the origin. So I wanted to ask, may I reopen this PR after forking it from here with the same changes? The reason for forking the original one is that I wanted to have access to the newest tree, so I can see if some issues are still active.

alexandruradovici commented 1 year ago

Please rebase it to the Tock master and force-push it here.

alexandruradovici commented 1 year ago

Send it to upstream and post a link.

RaresCon commented 1 year ago

https://github.com/tock/tock/pull/3385