UPB-CS-OpenSourceUpstream / tock

A secure embedded operating system for microcontrollers
https://www.tockos.org
Other
2 stars 6 forks source link

Implementation of PWM functionality for RP2040 #9

Closed Ioan-Cristian closed 1 year ago

Ioan-Cristian commented 1 year ago

Pull Request Overview

This pull request adds PWM functionality for RP2040. It resolves #3.

Testing Strategy

This pull request was tested on Raspberry Pi Pico using both unit tests and integration tests.

TODO or Help Wanted

Running tests on other boards.

Documentation Updated

Formatting

Signed by: Ioan-Cristian CÎRSTEA, 335CC.

alexandruradovici commented 1 year ago

Please write in the Readme file that the rp2040 chip now knows PWM.

alexandruradovici commented 1 year ago

Please write your full name (I assume Ioan-Cristian CIRSTEA) and your group in the PR message. @Ioan-Cristian

Ioan-Cristian commented 1 year ago

Please write in the Readme file that the rp2040 chip now knows PWM.

Done.

Ioan-Cristian commented 1 year ago

Please write your full name (I assume Ioan-Cristian CIRSTEA) and your group in the PR message. @Ioan-Cristian

Done.

alexandruradovici commented 1 year ago

Please rebase or solve conflicts it so we can run the actions.

Ioan-Cristian commented 1 year ago

Please rebase or solve conflicts it so we can run the actions.

Conflicts should be now solved.

alexandruradovici commented 1 year ago

This looks good now, please change back the private comments to use // and and I think we are good to go. As soon as @valexandru approves this, I think you can start writing the pull request towards Tock.

Ioan-Cristian commented 1 year ago

This looks good now, please change back the private comments to use // and and I think we are good to go. As soon as @valexandru approves this, I think you can start writing the pull request towards Tock.

Done. Now I have to create a new pull request towards tock/tock?

alexandruradovici commented 1 year ago

Yes, please open a pull request to Tock and add here a link to that pull request.

Ioan-Cristian commented 1 year ago

Opened a pull request at tock#3372.

alexandruradovici commented 1 year ago

Nice work for this pull request, what about trying one of the advanced issues that we posted?

Ioan-Cristian commented 1 year ago

This week I'm pretty busy, but I'll take a look at the Wi-Fi driver for Raspberry Pi Pico W next week (I don't own an SMT32 board).

alexandruradovici commented 1 year ago

This week I'm pretty busy, but I'll take a look at the Wi-Fi driver for Raspberry Pi Pico W next week (I don't own an SMT32 board).

We can give you an stm board.

Ioan-Cristian commented 1 year ago

This week I'm pretty busy, but I'll take a look at the Wi-Fi driver for Raspberry Pi Pico W next week (I don't own an SMT32 board).

We can give you an stm board.

Then I will announce you if I decide to start working on the Ethernet driver. Thank you very much!

valexandru commented 1 year ago

Hello, I saw that you created a merge request on the main repository and that you have some issues with checks that are failing. Just a small helpful tip, in order to be able to merge the PR you'll have to solve all the issues and you can find the errors by clicking on details and then viewing the logs, such as: https://app.netlify.com/sites/docs-tockosorg/deploys/63bc585704fd840008253b56 .

Ioan-Cristian commented 1 year ago

Hello, I saw that you created a merge request on the main repository and that you have some issues with checks that are failing. Just a small helpful tip, in order to be able to merge the PR you'll have to solve all the issues and you can find the errors by clicking on details and then viewing the logs, such as: https://app.netlify.com/sites/docs-tockosorg/deploys/63bc585704fd840008253b56 .

Sorry for not paying attention to this! I think I fixed the issue. I will check the pull request for any updates and comments as often as possible.

alexandruradovici commented 1 year ago

@Ioan-Cristian Please select a timeslot for the interview https://doodle.com/meeting/participate/id/eZ8gOOEb.

Ioan-Cristian commented 1 year ago

@alexandruradovici I have chosen a timeslot. Thank you!

alexandruradovici commented 1 year ago

Please send me your email address (using Teams maybe).