search

UPB-FILS-SdE2 / questions

0 stars 1 forks source link

[filesystem] Vague command requirement #110

Closed popescuatopg closed 5 months ago

popescuatopg commented 5 months ago

The open command goes as follows "Cette fonction d'ouvrir un fichier en mode lecteure seule" which translated means that the file is to be opened in read-only mode (correct me if I'm wrong here). However, the signature of the corresponding command function expects a PermissionMode argument to be passed to it.

Questions:

  1. Is this discrepancy between the command requirement and the function signature intended?
  2. Which has higher precedence: the command requirement or the signature of the supplied function? (this is so I can default to one of the 2 in case a similar issue arises)
alexandruradovici commented 5 months ago

It is a mistake, the open function opens a file with the requested permissions. Please send us a pull request.

popescuatopg commented 5 months ago

Created PR in upb-fils-sde2.github.io. Once the changes are merged, I'll proceed to close this PR.

alexandruradovici commented 5 months ago

Thank you, the homework should be updated.