UPB-FILS-SdE2 / questions

0 stars 1 forks source link

Rustyloader wrong tests #119

Closed popescuatopg closed 3 months ago

popescuatopg commented 4 months ago

From classroom.yml:

jobs:
  run-autograding-tests:
    runs-on: ubuntu-latest
    if: github.actor != 'github-classroom[bot]'
    steps:
    - name: Checkout code
      uses: actions/checkout@v4
    - name: build
      id: build
      uses: classroom-resources/autograding-command-grader@v1
      with:
        test-name: build
        setup-command: rustup target add i686-unknown-linux-gnu && sudo apt-get update
          && sudo apt-get -y install gcc-multilib
        command: cargo install --path .
        timeout: 10
    - name: setup
      id: setup
      uses: classroom-resources/autograding-command-grader@v1
      with:
        test-name: setup
        setup-command: git clone https://github.com/UPB-FILS-SdE2/devoir-3-tests.git
        command: cd devoir-3-tests/inputs && make
        timeout: 10

https://github.com/UPB-FILS-SdE2/devoir-3-tests leads to the last year's scheduler tests

MassaoudiOmar commented 4 months ago

Did you end up finding a repo that actually contains tests for this HW? I'm personally finding it impossible to decipher we have to do so that would be really helpful!

On Fri, May 24, 2024, 13:48 Popescu Adrian @.***> wrote:

From classroom.yml:

jobs: run-autograding-tests: runs-on: ubuntu-latest if: github.actor != 'github-classroom[bot]' steps:

  • name: Checkout code uses: @.***
  • name: build id: build uses: @.*** with: test-name: build setup-command: rustup target add i686-unknown-linux-gnu && sudo apt-get update && sudo apt-get -y install gcc-multilib command: cargo install --path . timeout: 10
  • name: setup id: setup uses: @.*** with: test-name: setup setup-command: git clone https://github.com/UPB-FILS-SdE2/devoir-3-tests.git command: cd devoir-3-tests/inputs && make timeout: 10

https://github.com/UPB-FILS-SdE2/devoir-3-tests leads to the last year's scheduler tests

— Reply to this email directly, view it on GitHub https://github.com/UPB-FILS-SdE2/questions/issues/119, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGWJ4EPQH6KMC7F3PN3S3WLZD4LJJAVCNFSM6AAAAABIHK4LJCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTKMBYG4YTQMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

popescuatopg commented 4 months ago

I did indeed found the tests from 2 years ago after posting this issue, but forgot to add a comment in here linking to the repo containing them, my bad there

https://github.com/UPB-FILS-SdE2/devoir-4-tests

Hope this helps!

alexandruradovici commented 4 months ago

Should be fixed now, please try it.