Bug: 17th debugging session

UPBGE / upbge

UPBGE, the best integrated game engine in Blender

https://upbge.org

Other

1.45k stars 180 forks source link

Bug: 17th debugging session #478

Closed youle31 closed 7 years ago

youle31 commented 7 years ago

BGMC 23:

Nuke/NUKE/levels/levelalley2.blend -> walk until you are taken by the police -> animation then crash
The hole/main_game.blend -> press P -> this exits bge immediately

youle31 commented 7 years ago

For the first bug, this: http://pasteall.org/382131/diff seems to avoid the crash. Indeed when replacing KX_Scene, the old was calling KX_Scene destructor and m_animatedlist->Release(); was called. Then I think the new scene was trying to add m_animatedlist->Add(gameobj); whereas m_animatedlist had already been removed... I'm not sure of the fix but it seems to avoid the crash

youle31 commented 7 years ago

For the second bug, it seems related to new events system. It didn't worked in 0.1.5 neither in 0.1.6. The python script throws an exception and endgame when there is a problem. So I think we can accept this little backward compatibility issue and let the user adapt his event manager with new upbge system.

panzergame commented 7 years ago

@youle31 : For the first bug can you try the branch ge_animation ?

youle31 commented 7 years ago

@panzergame : It's ok :)

panzergame commented 7 years ago

For the second report it's because the user us the raw value of the enum for key ESC (in game_input.py), previously it was 130 but with the new event system some of the unused enum where removed and the other shifted. I can restore the number, but in this case it will break the file using the same dirty method currently running in UPBGE...

Anyway this method is strongly deprecated.

youle31 commented 7 years ago

ok. So feel free to close when you want.