search

UPS-API / api-documentation

MIT License
32 stars 19 forks source link

Shipping: no need to `base64` if `ImageFormat` is `*PL` #87

Closed xerc closed 2 months ago

xerc commented 2 months ago

[\r\n] => null ^\s+|\s+$ => null

& new variable-name ?!

btw/ not always hints to (smaller size) PNG @ Shipping API

UPSRahul commented 2 months ago

Hi, would you mind providing a bit more context behind this inquiry?

xerc commented 2 months ago

remove the line-breaks and emtpy lines in start & end if the *PL - there will be no need to base64encode anymore will result in less cpu-cycles (on both sides) and less trafic/better gzip

UPSRahul commented 2 months ago

Hi, we appreciate the suggestion, but at this time, we will not be able to update this due to the large number of customer integrations we currently have and the potential for issues to arise.

xerc commented 2 months ago

kk ; NOT "completed" => "not planned"