Read-only whiteboard on session end

UPchieve / web

Online real-time tutoring platform

https://app.upchieve.org

Other

22 stars 22 forks source link

Read-only whiteboard on session end #522

Closed jkeat closed 4 years ago

jkeat commented 4 years ago

Description

Make whiteboard read-only on session end
Fixes issue caused by interacting with whiteboard that had been cleared from the server's doc cache

Developer self-review checklist

[ ] Potentially confusing code has been explained with comments
[ ] No warnings or errors have been introduced; all known error cases have been handled
[ ] Any appropriate documentation (within the code, README.md, docs, etc) has been updated
[ ] All edge cases have been addressed

treystevens commented 4 years ago

Update: If I backspace after the session ends and rejoin it by using the forward button, I'm able to write on the whiteboard - not sure if still intended

jkeat commented 4 years ago

Update: If I backspace after the session ends and rejoin it by using the forward button, I'm able to write on the whiteboard - not sure if still intended

You don't get the modal saying "Session Fulfilled; This session has already finished" ?

treystevens commented 4 years ago

Ah, I was clicking outside of the modal and then writing on the whiteboard. I'm thinking we should make those modals not be able to close outside of the clicking the action button. I think I changed the behavior when we were rethinking the modal situation