search

UPcload / FitAnalytics-WebWidget-iOS

FitAnalytics WebWidget SDK for iOS
MIT License
4 stars 5 forks source link

Universal framework with a defined iOS deployment target #2

Closed bobergj closed 6 years ago

bobergj commented 7 years ago

Rather than the app incorporating the FITAWebWidget source code into it's build target, there should be a xcode project that builds a FitAnalytics universal framework. Why? - When we update the iOS deployment target to iOS 10.0 for our app, we get deprecation warnings for some methods in FITAWebWidget. We don't want to fix those warnings by maintaining our own branch of this repository. A FitAnalytics framework with the deployment target set to the appropriate version (iOS 9?) would solve that, and naturally we'd prefer that such a build target be maintained in this repository.

tjelen commented 7 years ago

Thanks for the suggestion - we're definitely considering doing that.

bobergj commented 6 years ago

Please consider, we are now using deployment target iOS 10.0, and get these errors (we compile with warnings as errors) in In FITAWebWidget.m:

'openURL:' is deprecated: first deprecated in iOS 10.0 - Please use openURL:options:completionHandler: instead

Every time we update the SDK we have to merge our fix that replaces these method calls.

tjelen commented 6 years ago

This should be resolved with the latest release (v0.4.2) which includes the universal framework build project. Binary builds are attached as a downloadable files with each release from now on.