search

UPennEoR / RIMEz

Methods and input models for computing visibilities
MIT License
1 stars 1 forks source link

Apply black formatting and add pre-commit hook #13

Closed plaplant closed 5 years ago

plaplant commented 5 years ago

This PR adds a pre-commit hook for black. It also applies black-style formatting to the whole repo. This will make code style easy to maintain going forward.

Closes #5.

plaplant commented 5 years ago

@zacharymartinot there are a couple of issues that came up in the PR that I'd like to get your input on.

  1. In rime_funcs.py, near the bottom, there is a mysterious import from an interpolate module (interpolate.splprep and interpolate.splev). Is this part of the Fortran compiled stuff? Or is it from scipy?
  2. In management.py, there is an import of __path__, but I didn't see this defined in the __int__.py or setup.py. Is this defined somewhere?

I've also removed a few variable definitions that flake8 was reporting as not being used, but without tests running, it's not clear if these were important or breaking changes.

plaplant commented 5 years ago

Thanks for reviewing @steven-murray! I've removed the repeated # characters.

plaplant commented 5 years ago

@zacharymartinot one other change I made on flake8's recommendation was to rename a variable in management.py from I -> Iflux. However, I noticed that this was being written to HDF5 files with a dataset named I as well, so I changed that to Iflux to be self-consistent. This does mean that we're not backwards compatible with files that have a dataset just named I, so we may want to build in some code to handle this if there are a lot of such files. Just wanted to let you know about this change.