search

UPetit / python-binance-profit

Script to submit a buy order followed by an automatic sell OCO order
MIT License
47 stars 15 forks source link

issue OCO #27

Closed seanjeanc closed 3 years ago

seanjeanc commented 3 years ago

Hi!

Thanks for the work put into this. I am following instructions in your readme file.

I am buying at market price, but I get this error sometimes, but not all the time. Not sure what the issue could be.

File "/home/user/python-binance-profit/app/client.py", line 424, in execute_sell_strategy oco_order = OCOOrder( File "pydantic/main.py", line 400, in pydantic.main.BaseModel.init pydantic.error_wrappers.ValidationError: 2 validation errors for OCOOrder root The price is not valid compared to current avg trades. (type=value_error) root The price is not valid compared to current avg trades. (type=value_error)

I have tried selling my spot position and starting all over again, but same error.

UPetit commented 3 years ago

Hi @seanjeanc,

It seems like the calculated selling prices are off-limit as per Binance rule.

At this line each price calculated (profit price and the stop loss price) is checked against the Binance rule: they should stay between a certain range based on the average price of the recent trades.

Could you please tell me what were your parameters when you ran the script? What profit and loss % did you select?

seanjeanc commented 3 years ago

Thanks for replying,

Issue is not happening anymore. Strange.

Will re-open issue if I see it happening again!