search

UQ-PAC / BASIL

Apache License 2.0
8 stars 0 forks source link

Factor out aarch64 heuristics into a separate module #170

Open ailrst opened 8 months ago

ailrst commented 8 months ago

Calling convention constants such as the stack pointer, link register etc should be defined in a separate file so they aren't mixed all through the analyses.

l-kent commented 8 months ago

I don't really follow what you're proposing, you will have to describe it in more detail.

ailrst commented 8 months ago

We have constant such as Variable("R31", BitVecType(64)) spread throughout the static analysis, as well as structures like pattern matching on IndirectCall(R30), these should be centralised.

l-kent commented 8 months ago

I can only see the stackPointer etc. constants defined once each in the VSA and MRA (with the stack pointer once more in the visitor that identifies the stack) and no pattern-matching on IndirectCall(R30) anywhere?