search

UQComputingSociety / uqcsbot-slack

:mortar_board: UQCSbot: our friendly little Slack bot
https://slack.uqcs.org.au
MIT License
55 stars 44 forks source link

Add Asciify #373

Closed adriant4456 closed 6 years ago

adriant4456 commented 6 years ago

Adds asciify feature, closes #343

mitchmcdee commented 6 years ago

apologies for the delayed review, am super busy rn but will try and look at this at some point!

adriant4456 commented 6 years ago

No problem, I'm still working on improving the tests with unittest mock

adriant4456 commented 6 years ago

I've implemented most of @TRManderson recommendations. One weird thing I found was trying to import the error message strings from the ascii.py script caused NotImplementedError exceptions for all the ascii tests. Thoughts @mitchmcdee ?

mitchmcdee commented 6 years ago

yeah this is a known issue, just duplicate the strings for now