search

UQComputingSociety / uqcsbot-slack

:mortar_board: UQCSbot: our friendly little Slack bot
https://slack.uqcs.org.au
MIT License
55 stars 44 forks source link

Added !dominos #379

Closed ldgrp closed 6 years ago

ldgrp commented 6 years ago

Reimplements dominos.js

nicklambourne commented 6 years ago

lgtm, can you test it in the uqcstesting slack and throw up some images?

ldgrp commented 6 years ago

screenshot 2018-09-13 22 36 05

nicklambourne commented 6 years ago

@TRManderson can you give this a quick onceover/lgtm (+ thoughts on list over List[type] in typing) and I'll merge it?

TRManderson commented 6 years ago

Looks really good, but having some tests would be nice.

@ldgrp - check out https://docs.python.org/3/library/typing.html RE your type annotations.

list is effectively List[Any]

ldgrp commented 6 years ago

I'll try mimicking the tests for !umart if that's alright