search

UQComputingSociety / uqcsbot-slack

:mortar_board: UQCSbot: our friendly little Slack bot
https://slack.uqcs.org.au
MIT License
55 stars 44 forks source link

Create `!bgg` command #542

Closed bradleysigma closed 4 years ago

bradleysigma commented 4 years ago

Creates the !bgg command, which uses the Board Game Geek API to fetch data about the required board game.

image

nicklambourne commented 4 years ago

I will merge zero PRs containing single letter variable names.

bradleysigma commented 4 years ago

I will merge zero PRs containing single letter variable names.

Clearly False: https://github.com/UQComputingSociety/uqcsbot/pull/539/files

jdcaperon commented 4 years ago

rekt

nicklambourne commented 4 years ago

Correction: I will merge zero PRs containing single letter variable names ever again. I should definitely have pulled @JamesDearlove up on some of those.

bradleysigma commented 4 years ago

@nicklambourne variables have been desingletonned.

bradleysigma commented 4 years ago

numplayers, numvotes and friendlyname are named after the XML attribute from the API, and so were not made snake_case.