search

UQComputingSociety / uqcsbot-slack

:mortar_board: UQCSbot: our friendly little Slack bot
https://slack.uqcs.org.au
MIT License
55 stars 44 forks source link

create factorial response #545

Closed bradleysigma closed 3 years ago

bradleysigma commented 4 years ago

Calculates factorials. Aggressively. image

jdcaperon commented 4 years ago

I don't see it being triggered a lot, but people will probably complain about it.

nicklambourne commented 4 years ago

So if I say something like "They only gave you 18!," this is going to trigger? Is there any reason it can't operate on demand like the other scripts? !factorial 18

bradleysigma commented 4 years ago

Correct. Because it's more amusing this way.

kumar-ish commented 4 years ago

I also don't think it'll be triggered too often but it'll mildly annoying. With that said, if you make it to be a(n im)probabilistic event (say, if random.random() < 0.1) I think it's fine.

nicklambourne commented 4 years ago

@bradleysigma I think Madhav's suggestion is good. If you set the probability at 5% or less and mock the probability for the test I'll review and merge this.