UQComputingSociety / website

The UQ Computing Society website.
https://uqcs.org
Apache License 2.0
11 stars 91 forks source link

Added 'LoFi-ify' project to showcase page. #298

Closed 4lon closed 2 years ago

4lon commented 2 years ago

Adding the hackathon LoFi-ify project to the showcase. I'm aware that my img src is a link to a file in the project repo, the website didn't seem to want to render the apng when stored locally but didn't seem to have an issue with it when referencing an external link. The project link is also dependent on the url staying the same so I didn't feel like this is adding any unnecessary reference dependencies. Let me know if this is an issue and if you have a recommended solution to fix the webpage not rendering the file when stored locally.

andrewj-brown commented 2 years ago

If you have a recommended solution to fix the webpage not rendering the file when stored locally.

My recommended-albeit-tricky solution is to switch to a different file format. Your image looks theoretically SVG-able, but animating that may be a hassle (crisp vector graphics though😩). Try a .gif perhaps?

4lon commented 2 years ago

gif had the same none rendering issue but also created weird aliasing artefacts when shrunk down to the size used in the showcase tiles. There is a chance that this issue might just be on local deployments but not sure how to test that. There is one idea I have but it feels a little janky to me. I could put up a broken url that points to where this file would be in this repo once the pull request is accepted. So for example I would use the link "https://github.com/UQComputingSociety/website/blob/a061b67a0d80df49ebc401ba12d7d36e8fc99bcf/static/img/media/showcase/lofi.apng?raw=true" and commit the file to where other showcase images are stored. This would point to this repo so it should work just like the current implementation but the file would be stored in a UQCS location. It does mean we couldn't tell if it works until the pull request would be accepted since the link wouldn't be valid until post pull request.

Could also just try it with the same format as everyone else's project images to see if the issue is only apparent on local deployments and if it doesn't work then update it to the url example above using the file that would now already be in the repository but I am aware this 'trying' entails deploying it on the website live before knowing if it works 😬.

andrewj-brown commented 2 years ago

gif had the same none rendering issue but also created weird aliasing artefacts when shrunk down to the size used in the showcase tiles. There is a chance that this issue might just be on local deployments but not sure how to test that.

If you're having this issue with multiple different file formats I suspect it's a local thing, tag @JamesDearlove can probably help with that.

4lon commented 2 years ago

I replaced the url and confirmed it was a local development problem, you can use the command "hugo server --disableFastRender" which fixes the issue, I guess it was a problem that the new resource was not being included when updated. I think that means it should work when deployed.

Thomas-Malcolm commented 2 years ago

LGTM, merging