UQcsse3200 / 2023-studio-3

MIT License
1 stars 4 forks source link

Team 2 UI Feature and Team 2/5 In-Game build menu collab #215

Closed The-AhmadAA closed 11 months ago

The-AhmadAA commented 11 months ago

This PR brings in the implementation of In-game UI elements, and the In-Game Tower build menu Specifically:

There are additional improvements/integration possible, but these are dependent on other features. Please feel free to ask questions or provide feedback as necessary.

ryandmcneilly commented 11 months ago

Hey just some small issues I noticed, when the player picks less than 5 turrets the game crashes (IndexOutOfBounds) however when you pick 0 zero turrets the game still works (just noticed this is a known issue on discord). Also when you try and select multiple towers it seems the buttons stay highlighted causing some bugs. Apart from that looks good!

The-AhmadAA commented 11 months ago

Hey just some small issues I noticed, when the player picks less than 5 turrets the game crashes (IndexOutOfBounds) however when you pick 0 zero turrets the game still works (just noticed this is a known issue on discord). Also when you try and select multiple towers it seems the buttons stay highlighted causing some bugs. Apart from that looks good!

Hey Ryan, thanks for the feedback, this all seems to be related to Turret Select Screen, so will need to consult with the author. It currently doesn't affect gameplay if all or no towers are selected, we can probably deal with this in a Bug report ticket

The-AhmadAA commented 11 months ago

This PR now also includes updating of buttons globally using the newly built Skin "glass.json"