search

UQcsse3200 / 2023-studio-3

MIT License
1 stars 4 forks source link

Team 4 - Waves - Final Code Smell Fixes & New Tests for WaveService Added. #298

Closed max9753 closed 1 year ago

max9753 commented 1 year ago

This will be our final PR I think which fixes several code smells and add some new testing coverage to WaveService in WaveServiceTest.java.

Should be no conflicts as these files should not have been touched by anyone else hopefully :).

Happy reviewing!

max9753 commented 1 year ago

Hi, LGTM no apparent bugs found Just wondering, does this make the WaveTaskTest (that is ignored) redundant?

yes, perhaps but I wont mess with that one because I don't remember making it I think it was another member.