search

UQcsse3200 / 2024-studio-3

MIT License
6 stars 0 forks source link

Significant Lagging after Picking Up Item #226

Closed Hayden-Elliott closed 5 days ago

Hayden-Elliott commented 6 days ago

Description

On picking up item from tree, game significantly lags and ultimately freezes

How To Reproduce

Steps to reproduce the behaviour:

  1. Go to tree
  2. Click 'E' to interact
  3. Experience lags and slow down

Expected Behaviour

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional Context

Occurred after attached merge, changing how player sprite is updated when holding item: https://github.com/UQcsse3200/2024-studio-3/pull/225

Suspected error caused by this merge due to known functionality of other interaction components from previous main versions

Temporary Fix

None at present

Hayden-Elliott commented 6 days ago

After investigation, wasnt working before the given merge either, may be related to changes in Inventory display since

Hayden-Elliott commented 6 days ago

Doesn't look to be caused by that after commenting out updates, continuing investigation

Hayden-Elliott commented 6 days ago

Error found, in PlayerActions some old cod meant to freeze player on some interactions became uncommented, was trigger event in KeyboardPlayerInputComponent that messed with movement. Submitting fix, just commenting out trigger