This is our final pull request for this sprint. We have added the fire extinguisher and plate player sprite which were not included in the previous PR. We also originally added some testing for the player interactions which was passing however had to be commented out due to the whole structure of the inventory display being modified. The tests failed we even after debugging because these changes added to the main were made wednesday we ran out of time. The rest of our code for this sprint was not modified.
Fixes / Closes # (issue)
134 (last two items to be implemented)
Type of change
[ ] Last few changes (non-breaking change which adds functionality)
How Has This Been Tested?
For the benches, the createBench could not really be tested since it is a static method calling other methods. And the benches are simply being spawned at specific coordinates so the only way we could test this was to confirm the values coming in are being passed through properly. For the player animations, each direction was tested using verify to make sure the correct animations were being started. The player interaction with items was initially tested with the prior implementation of the inventory display. The rest was also checked by interacting with items when moving the player and looking at the sprite.
Checklist:
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
This is our final pull request for this sprint. We have added the fire extinguisher and plate player sprite which were not included in the previous PR. We also originally added some testing for the player interactions which was passing however had to be commented out due to the whole structure of the inventory display being modified. The tests failed we even after debugging because these changes added to the main were made wednesday we ran out of time. The rest of our code for this sprint was not modified.
Fixes / Closes # (issue)
134 (last two items to be implemented)
Type of change
How Has This Been Tested?
For the benches, the createBench could not really be tested since it is a static method calling other methods. And the benches are simply being spawned at specific coordinates so the only way we could test this was to confirm the values coming in are being passed through properly. For the player animations, each direction was tested using verify to make sure the correct animations were being started. The player interaction with items was initially tested with the prior implementation of the inventory display. The rest was also checked by interacting with items when moving the player and looking at the sprite.
Checklist: