UQcsse3200 / 2024-studio-3

MIT License

6 stars 0 forks source link

Team3/code smells components npc #647

Closed Caleb-J-Murphy closed 4 weeks ago

Caleb-J-Murphy commented 4 weeks ago

Description

Fixed all 21 code smells and removed any warnings for the files in the game/components/npc/ folder. These warnings were taken from the SonarCloud

Closes #505

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] CustomerManager.java
[ ] GhostPositionManagerComponent.java
[ ] CustomerComponentTest.java
[ ] CustomerManagerTest.java
[ ] PersonalCustomerEnumsTest.java

Run: ./gradlew build to run the tests

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules