UQdeco2800 / 2022-studio-2

MIT License
5 stars 1 forks source link

[Collaboration] Crafting System Sounds #249

Closed jgapusan closed 2 years ago

jgapusan commented 2 years ago

Feature: Optimisation and Enhancement of Crafting System + Additional Features

Description

Design and implement crafting system sounds and sounds for other related features.

Milestones

List of steps that need to be completed for this task.

Completion Deadline: Oct 12th

Documentation

Members

jgapusan commented 2 years ago

@uq-haze how did you want to include your voice in our crafting sounds?

uq-haze commented 2 years ago

@jgapusan maybe when the player crafts a weapon, there will be a voice over that says 'weapon crafted' or something along those lines

jgapusan commented 2 years ago

@uq-haze sounds good! if you could send thru a few variations for user testing asap that’d be great - have fun w it haha

jgapusan commented 2 years ago

for reference these are the sound FX for the weapon crafted sound https://freesound.org/people/ash_rez/sounds/518888/ https://freesound.org/people/cameronmusic/sounds/138410/ https://freesound.org/people/axilirate/sounds/592346/

uq-haze commented 2 years ago

aight let me record some variation

uq-haze commented 2 years ago

Weapon Crafted Variants.zip @jgapusan alright here are the voice lines cringe to your hearts content XD

jgapusan commented 2 years ago

oh my it’s beautiful >_<

just last request if you edit the file so the voice plays immediately, the milliseconds of gap causes a weird disconnect from the popup and the sound ;-;

no rush it wont affect programming or any of that so u have til end of sprint for it :D in fact once my user testing is complete i’ll let you know which one in particular will be used - save you some work :D thx tho everything sounds great so far

uq-haze commented 2 years ago

alright will do! Let me know when you've gotten user testing results and ill edit the voice files

lyphng commented 2 years ago

It's been implemented! You guys can view the details in these two commits: https://github.com/UQdeco2800/2022-studio-2/commit/5eb738ff2a53e81fc9ffc57e49b392a46b0d2287 https://github.com/UQdeco2800/2022-studio-2/commit/5d736ea33ef70bd2e3901f34a5c7e730f003d97c