search

US-CBP / cbp-theme

UI Theme for U.S. Customs and Border Protection web applications
https://us-cbp.github.io/cbp-theme
Other
28 stars 36 forks source link

Universal header button icon bug fix #384

Closed minjungb closed 3 years ago

minjungb commented 3 years ago

What's this PR do?

  1. Includes fix for issue where clicking directly on the icon of the buttons did not trigger the dropdown.
  2. Changed custom typography access from mixins to html classes.

Where should the reviewer start?

  1. cbp-header.scss (should no longer have any mixins)
  2. universalHeader.html (should include text classes)

How should this be manually tested?

image

  1. comment out cbp-theme-settings/cbp-appHeader, and remove comment from cbp-theme-settings/cbp-header.
  2. gulp build-sass and check universalHeader.html to check that the button bug is fixed and everything else is working properly.

    Any background context you want to provide?

    What are the relevant tickets?

    Screenshots (if appropriate)

    Questions:

    • Is there a blog post?
    • Does the knowledge base need an update?