US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Bug: Component Type #5876

Open acollad1 opened 8 months ago

acollad1 commented 8 months ago

Issue: Selection of Component ID/Type is not associated with the selected system

Steps to Recreate:

Private Zenhub Image

JanellC commented 8 months ago

Upon further review, bug is not clear. Will discuss with EPA before working on this issue

JanellC commented 8 months ago

Based on discussion during DSU on 11/2 this is a non issue

acollad1 commented 7 months ago

Per conversation with POs ticket is to be reopened and new scope is to remove filtering altogher

jwhitehead77 commented 7 months ago

I do not recommend removing this filtering from the dropdown becasue the component being added must be a component specific to the monitor location that is not already associated to the system. If that filtering is removed then the backend api is going to throw an error either via a check and/or db referential integrity constraint if not caught by a check.

esaber76 commented 4 months ago

Confirm if still a bug.

esaber76 commented 3 months ago

Per 3/27/2024 standup with EPA, the Add Component dropdown list should include all of the components associated with a monitor location that are NOT already active at the system. The dropdown is currently displaying the components already associated with a particular system.

Curtis H. Stanton Energy Center (ORIS 564), unit 1. System 160's active components:

image

Current dropdown displays the same components:

image

This list should not include any of these components but instead component IDs: 016, 017, 101, 105, 106, 107, 108, 109, 110, 111, 115, 151, 152, 251, 252, P99.

Note: If a component ID is/was ended for a monitor system and is no longer active for that system, it should appear in the dropdown.

lgiannini1 commented 3 months ago

For ORIS 3470, configuration WAP8, MS1, MS2, the list of components displays all components not currently associated with the system, but when adding one of these components to a system it will then appear twice in the dropdown instead of disappearing for all systems. Ending an active component and adding it back to the system results in the same issue.

Steps to recreate:

  1. Check out W.A. Parish WAP8,MS1,MS2
  2. Select MS1 and View/Edit for System SO2 -> Add Component
  3. Select component SO2, continue, add a begin date/ hour of 01/01/2024, hour 0, and click Add Existing Component Image
  4. Select View/Edit for System SO2 -> Add Component. There will be two records for component SO2.Image
esaber76 commented 2 months ago
  1. Components that were at one time ended and re-added as active still show in the dropdown list even though their current state is active. The same would be true when re-adding a previously ended component. This is a very common scenario for fuel flowmeters that are rotated in and out of service. ORIS 404, 1 is a good example.

Component ID 114 already active: image

Component ID 114 still in selection list: image

esaber76 commented 2 months ago

Testing for this ticket is to confirm that the Add Component dropdown list displays the correct components.

  1. All components associated with a monitoring plan location that are not already active for that system should be displayed.
  2. If a component is or already was ended and is no longer active, it should appear in the dropdown.
  3. If an ended component is re-added as active, it should not display in the dropdown list.
maheese commented 2 months ago

Tested on ORIS 6002, unit 1. This is fixed.

  1. All components associated with a monitor location but not already added to the system now show in the drop down list.
  2. When an existing system component is ended it re-appears in the list to be added.
  3. If the component is re-added it is removed from the add list.