US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Add message for old and/or invalid evaluation reports #5894

Open JanellC opened 1 year ago

JanellC commented 1 year ago

Context

As discussed during DSU on 11/8 will complete the following in the scope of this ticket:

During DSU on 11/6 discussed adding an error message. This issue came out of the bug documented below.

Bug: Evaluation Email Report #5883 Issue: There are no details about the crititcal errors from link to Critical Errors in email Steps to Recreate:

Checkout 2493 config 60 Import 2023 Q1 QA test Expand Linearity Add Protocol Gas Add High on Gas Level Code Add Nitrogen Balance Gas, Carbon Dioxide, Nitric Oxide, Total Oxides of Nitrogen Gast Type Code Add CC1234567 in Cylinder Identifier Select Airgas USA, LLC, an Air Liquide Componany (NC) Add 10/31/2026 in Expiration Date Run evaluation on QA test View notification email https://usepa.sharepoint.com/sites/CAMDCVPTeam/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2FCAMDCVPTeam%2FShared%20Documents%2FECMPS%20Beta%20Testing%2F2023%2D10%2D27%20Screenshots%2FTEST%5FEVAL%5FEast%20River%5F2493%2Ehtml&parent=%2Fsites%2FCAMDCVPTeam%2FShared%20Documents%2FECMPS%20Beta%20Testing%2F2023%2D10%2D27%20Screenshots

shahbazkhan1999 commented 11 months ago

I will look into it

hamezene commented 11 months ago

Shahbaz will test locally and merge to develop

shahbazkhan1999 commented 11 months ago

If the reportCode contains "EVAL" and the evaluation status is "Pass"

image.png

If any errors occur while generating any report

image.png

If the reportCode contains "EVAL", evaluation status is NOT "Pass", and no errors

shahbazkhan1999 commented 11 months ago

@alangmaid you can test this on dev

ibarra-michelle commented 8 months ago

Summary: @chrisgitsit and @annalbrecht - UAT is complete and inconsistencies in displaying Eval messages still exist. We need to pull this ticket into a broader Evaluation Reports messaging requirements meeting to clarify what the requirements are and ensure the messages are displaying consistently across the modules.

Testing Summary:

  1. If any errors occur while generating any report

display "An error has occurred therefore a report cannot be generated at this time. Please check back later or contact support."

  1. If the reportCode contains "EVAL" and the evaluation status is "Pass"

display "Evaluation has passed without errors"

Conclusion: The display is inconsistent based on module, (e.g., Monitoring Plan and Emissions) and/or whether the user is logged in or out of the test environment. Below are two examples of the error:

  1. If the reportCode contains "EVAL", evaluation status is NOT "Pass", and no errors

display "Evaluation is old or expired and error data is no longer available"

Conclusion: When the user opens an old evaluation report, the user does not receive this error message. Below are two examples of the error. FYI - the link in the two different emails are the same link.

ibarra-michelle commented 8 months ago

Update: This ticket should be deployed to beta and a requirements meeting needs to be scheduled to gather the Eval Report requirements and generate tickets the appropriate tickets.

Also, this ticket #5894 is related to ticket #5954 (attach eval report to email). The three error messages should still be checked with ticket #5954 is pushed into test.