US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Monitoring Plan Schema Issue - unitControlData #5913

Open maheese opened 9 months ago

maheese commented 9 months ago

Developer Notes:

  1. Changing the type from varchar to "indicator" should also include JSON and database name changes to be consistent.
  2. The change to originalCode in the JSON should include changing the name to originalIndicator or originalControlIndicator.
  3. According to a later comment, the JSON OS field is seasonalControlsIndicator. "Seasonal" does not indicate Ozone Season and the field will be an indicator. So the name should be either osControlIndicator or seasonControlIndicator.
  4. The database names should also change from ORIG_CD and SEAS_CD to ORIG_IND and SEAS_IND or maybe ORIGINAL_CONTROL_IND and OS_CONTROL_IND (or SEASON_CONTROL_IND).
  5. The changes will involve Infomatica changes or potentially deployment changes to handle the name and type changes.
  6. The changes will likely involve check changes based on the type and name changes.
  7. And to explicitly state it, the changes will involve JSON export, JSON import, and Official import changes and testing.
  8. CAMD needs to indicate whether to pursue these changes. We would need to make these changes now or never.
maheese commented 9 months ago

In element unitControlData of the monitoring plan the properties originalCode and seasonalControlsIndicator are "indicators" and defined as strings with enumerated values null, “0”, and “1”. Other similar “indicator” fields are numeric with values null, 0, and 1. These fields need to be made consistent with the other indicator fields used in the schema.

This issue was reported by an industry user in Request Tracker ticket 73082

acollad1 commented 9 months ago

CVP confirms that there are strings in the database so we would not be able to make them consistent. They are exceptions.

acollad1 commented 9 months ago

On DSU 11/22 it was determined that EPA POs need further discussion on this before an action is taken

acollad1 commented 9 months ago

Jason to reach out to Dwayne to confirm that the proposed changes won't affect their work

annalbrecht commented 5 months ago

Verify if this needs to be changed.

maheese commented 5 months ago

@djw4erg thanks for looking into this. Since this is not show stopper we decided not to work on this for phase 1.