US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

compliance datasets do not include data for 2022 - Production Issue #6031

Open hamezene opened 10 months ago

hamezene commented 10 months ago

I was checking on bulk data files since we are expecting the transaction datasets to be updated with 2023 data next week, but noticed that the following compliance datasets do not include data for 2022 but they should. Can you look into this? I'm hoping this is just a database issue that can be resolved without a code change. The APIs/Custom Data Download are working fine and have the data. This is a production issue. Thanks!

CSOSG1

CSOSG2

CSOSG3

CSNOX

CSSO2G1

CSSO2G2

TXSO2

djw4erg commented 10 months ago

Bulk Files API Information:

Repository: easey-camd-services repository Swagger Page: camd-services Swagger page

djw4erg commented 10 months ago

Updated Information:

I asked Mark about the unfamiliar Bulk Data File process and he indicated the following:

The View Bug: The view compares the Last Update Dates in the ACCOUNT_COMPLIANCE_DIM and ACCOUNT_FACT tables to the current timestamp for the database. Using the current timestamp is wrong. The timestamp should be the begin time for the last time the specific Quartz job successfully ran.

Proposed Course:

djw4erg commented 10 months ago

Additional Issue: easey-quartz-scheduler/.../AllowanceComplianceBulkDataFiles.cs references 'Emissions Compliance' instead of 'Allowance Compliance' at line 72.

maheese commented 10 months ago

@djw4erg I was looking at the runbook and it does address database deployments in the context of a code release. Can we get the approach we discussed this morning for just database updates updated in the database deployments section of the runbook https://github.com/US-EPA-CAMD/easey-docs/blob/develop/CAMDRunbook.md#93-deployments as part of this issue.

ergjustin commented 9 months ago

quartz-scheduler bug fix PR : https://github.com/US-EPA-CAMD/easey-quartz-scheduler/pull/165

djw4erg commented 9 months ago

Updates for View Changes:

View: camdaux.vw_allowance_based_compliance_bulk_files_to_generate C# Class: BulkDataFileMaintenance class in EASEY-QUARTZ-SCHEDULER repository in //admin/Job/BulkDataFilesMaintenance.cs.

Notes:

ergjustin commented 9 months ago

db-script PR: https://github.com/US-EPA-CAMD/easey-db-scripts/pull/14

djw4erg commented 9 months ago

Follow-up Issues

  1. ACCOUNT_COMPLI(ANCE_DIM LAST_UPDATED_DATE is null for every row in Dev. What updates this date?