US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Updates for already submitted TEE's #6062

Open esaber76 opened 7 months ago

esaber76 commented 7 months ago

Users have the ability to remove and/or modify already submitted TEE's from their workspace. This could impact emissions evaluations. TEE's that need to be modified and/or removed should first be handled in the Admin tool.

yonatan-dp commented 2 months ago

Hi @esaber76 , for this ticket, I am assuming we will use the same acceptance criteria as in #6061 except that we are using camdecmpswks.test_extension_exemption and the camdecmps.test_extension_exemption tables with test_extension_exemption_id column as the identifier.

esaber76 commented 2 months ago

@yonatan-dp - yes.

lgiannini1 commented 2 months ago

Verified that previously submitted TEEs cannot be removed from the workspace. There are some issues though:

Image

yonatan-dp commented 2 months ago

@lgiannini1 Please retest, fix deployed to Dev.

lgiannini1 commented 2 months ago

Verified on dev.

ntknguyen commented 2 months ago
  1. Cannot verify
  1. Verified:

Image

yonatan-dp commented 2 months ago

@ntknguyen, I looked into this. The TEE data for Kyrene Generating Station, K-7 was not submitted. I verified this by checking in the database that it only existed in the camdecmpswks.test_extension_exemption table (it was not in the official record: camdecmps.test_extension_exemption). That is why you were able to see the "Remove" button. I run the following two queries to determine that:

--This returns one TEE data select * from camdecmpswks.test_extension_exemption tee where tee.mon_loc_id = '3914';

--This returns empty TEE data select * from camdecmps.test_extension_exemption tee where tee.mon_loc_id = '3914';

Just to make sure, I went ahead and "Reverted to Official" and the TEE data you screenshot disappeared (as it should since reverting to official will revert to the official data from the camdecmps schema).

I conclude from the above that the functionality is working as intended. Please let me know if I missed something in my analysis above.

ntknguyen commented 2 months ago

@ntknguyen, I looked into this. The TEE data for Kyrene Generating Station, K-7 was not submitted. I verified this by checking in the database that it only existed in the camdecmpswks.test_extension_exemption table (it was not in the official record: camdecmps.test_extension_exemption). That is why you were able to see the "Remove" button. I run the following two queries to determine that:

--This returns one TEE data select * from camdecmpswks.test_extension_exemption tee where tee.mon_loc_id = '3914';

--This returns empty TEE data select * from camdecmps.test_extension_exemption tee where tee.mon_loc_id = '3914';

Just to make sure, I went ahead and "Reverted to Official" and the TEE data you screenshot disappeared (as it should since reverting to official will revert to the official data from the camdecmps schema).

I conclude from the above that the functionality is working as intended. Please let me know if I missed something in my analysis above.

Thanks @yonatan-dp. The issue is now fixed.