Open annalbrecht opened 5 months ago
Need the list of screen checks that should be running in 2.0. Then check that the list of screen checks is running.
List of TEE screen checks from 1.0:
List of TEE screen checks currently in 2.0:
Lane: check to make sure these issues would be caught by an evaluation.
QCE Check Specs: https://ecmps.camdsupport.com/documents/ECMPS%20QA%20and%20Cert%20Check%20Specifications%202022%20Q1.pdf
Was able to reproduce the following for the few evaluations that I did:
The only change for this ticket: EXTEXEM-8: Need a check to stop people from manually adding a duplicate record in the TEE module.
In ECMPS 1.0, an import of TEE can introduce duplicates because import checks do not exist, and ECMPS 2.0 does not appear to have import checks that would produce duplicates.
I believe that we should produce a ticket to check for duplicates, but that the ticket does not need to be implemented before the release.
Ticket created as #6308
I am able to generate the EXTEXEM-8 error code both for screen and import without making any code changes.
Please see screenshots below.
There is a slight difference in how duplicates are handled for screen vs import.
For screen entries, the code checks if a duplicate exists in the database.
For imports, the code checks if duplicate TEE's exist in the import file.
This logic also applies to 5786.
Verified on dev. Was able to generate EXTEXEM-8-A screen check by attempting to add a duplicate 2019 Q1 TEE record for ORIS 3, CS0AAN and importing the attached QA file which contains duplicate TEE records. Also verified that new TEE records can still be added through the UI and through file import.
Verified receiving screen check on duplicate TEE record and adding new TEE record from Add option, but still getting screen check [EXTEXEM-8-A] on importing new TEE record using the attachment json.
@ntknguyen , I looked at your attached JSON file and it has duplicate TEE records. The two TEEs in the JSON are exact duplicates. Can you change some of the values for one of the records and try your import again? Change the Extension/ Exemption Code, Year, Quarter, Monitoring System ID, Component ID, or Fuel Code for one of the records so that they are not duplicates and try again.
I verified this issue is fixed.
Overview
This ticket is an offshoot of #5786 which identified that screen checks were not implemented for TEE and QCE. The decision was made to only implement the screen checks that were not also implemented as report checks. For TEE, EXTEXEM-8, which has result A, is the only screen check that is not also a report check. So this ticket was created to implement EXTEXEM-8 as a screen (and import) check.
Original Description
Originally reported in #5786. TEE screen checking needs to be added. Requirements needed.
Acceptance Criteria: