Add EXTEXEM-8 TEE check

[annalbrecht]

Overview

This ticket is an offshoot of #5786 which identified that screen checks were not implemented for TEE and QCE. The decision was made to only implement the screen checks that were not also implemented as report checks. For TEE, EXTEXEM-8, which has result A, is the only screen check that is not also a report check. So this ticket was created to implement EXTEXEM-8 as a screen (and import) check.

Original Description

Originally reported in #5786. TEE screen checking needs to be added. Requirements needed.

Acceptance Criteria:

• [ ] Check result EXTEXEM-8-A is returned when a user uses the screen to enter a TEE record with an Extension/ Exemption Code, Year, Quarter, Monitoring System ID, Component ID, and Fuel Code that matches an existing TEE record.

[annalbrecht]

Need the list of screen checks that should be running in 2.0. Then check that the list of screen checks is running.

[lgiannini1]

List of TEE screen checks from 1.0:

• EXTEXEM-1 - Test Extension/Exemption Year and Quarter Valid
• EXTEXEM-2 - Test Extension/Exemption Extension or Exemption Code Valid
• EXTEXEM-3 - Test Extension/Exemption System Valid
• EXTEXEM-4 - Test Extension/Exemption Component Valid
• EXTEXEM-5 - Test Extension/Exemption Span Scale Valid
• EXTEXEM-6 - Test Extension/Exemption Fuel Code Valid
• EXTEXEM-7 - Test Extension/Exemption Hours Used Valid

List of TEE screen checks currently in 2.0:

• Does not appear that any TEE screen checks have been implemented. I was only able to generate errors by leaving the Year and Quarter fields blank. This should generate a EXTEXEM-1-A check message.

[annalbrecht]

Lane: check to make sure these issues would be caught by an evaluation.

QCE Check Specs: https://ecmps.camdsupport.com/documents/ECMPS%20QA%20and%20Cert%20Check%20Specifications%202022%20Q1.pdf

[lgiannini1]

Was able to reproduce the following for the few evaluations that I did:

• EXTEXEM-2-B,C
• EXTEXEM-3-A,B,C
• EXTEXEM-4-A
• EXTEXEM-5-A
• EXTEXEM-6-B,D
• EXTEXEM-7-B,D
• EXTEXEM-8-A fires on import of duplicate TEE record, but not if you add one manually in TEE module and evaluate.
• EXTEXEM-9-A,B

[annalbrecht]

The only change for this ticket: EXTEXEM-8: Need a check to stop people from manually adding a duplicate record in the TEE module.

[djw4erg]

Potential New Ticket

In ECMPS 1.0, an import of TEE can introduce duplicates because import checks do not exist, and ECMPS 2.0 does not appear to have import checks that would produce duplicates.

I believe that we should produce a ticket to check for duplicates, but that the ticket does not need to be implemented before the release.

Ticket created as #6308

[yonatan-dp]

I am able to generate the EXTEXEM-8 error code both for screen and import without making any code changes.

Please see screenshots below.

There is a slight difference in how duplicates are handled for screen vs import.

For screen entries, the code checks if a duplicate exists in the database.

• If a duplicate exists, it displays the EXTEXEM-8 error message.
• If a duplicate does not exist, it creates a TEE record.

For imports, the code checks if duplicate TEE's exist in the import file.

• If duplicates exist in the import file, then it displays the EXTEXEM-8 error message.
• If duplicates do not exist in the import file, then it attempts to pull a matching TEE record from the database based on the location ID, Extension/ Exemption Code, reporting period, Monitoring System ID, Component ID, and Fuel Code.
  • If such a record exists, it simply updates the record.
  • If there is no record based on the above parameters, it creates a new TEE record.

This logic also applies to 5786.

[lgiannini1]

Verified on dev. Was able to generate EXTEXEM-8-A screen check by attempting to add a duplicate 2019 Q1 TEE record for ORIS 3, CS0AAN and importing the attached QA file which contains duplicate TEE records. Also verified that new TEE records can still be added through the UI and through file import.

QA & Certification _ Export - Barry (10).json

[ntknguyen]

Verified receiving screen check on duplicate TEE record and adding new TEE record from Add option, but still getting screen check [EXTEXEM-8-A] on importing new TEE record using the attachment json.

QA.Certification._.Export.-.Barry.CS0AAN.json

[yonatan-dp]

@ntknguyen , I looked at your attached JSON file and it has duplicate TEE records. The two TEEs in the JSON are exact duplicates. Can you change some of the values for one of the records and try your import again? Change the Extension/ Exemption Code, Year, Quarter, Monitoring System ID, Component ID, or Fuel Code for one of the records so that they are not duplicates and try again.

[ntknguyen]

I verified this issue is fixed.