search

US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Update CROMERR Signature Process for ICAM #6208

Open yonatan-dp opened 7 months ago

yonatan-dp commented 7 months ago

Currently when a user user attempts to sign a submission, ECMPS authenticates by prompting the user for a user id, password, and a challenge question that was setup during user signup. In the new ICAM implementation, the prompt for user id, password, and challenge question will be removed. It will instead be replaced by a call to new CDX REST APIs to create the signing activity in CROMERR.

To see current functionality ECMPS, go through the test plan submission flow.

Old way of signing in CROMERR through ECMPS once the user chooses to sign a document

New way of CROMERR services

Development Notes

See below for further details (disregard the use of provided ui widgets to implement functionality)

https://usepa.sharepoint.com/sites/CAMDCVPTeam/Shared%20Documents/Forms/AllItems.aspx?csf=1&web=1&e=8IxcZg&cid=a5be18a8%2D83e1%2D4e74%2D98e5%2D6b99fa3b190c&FolderCTID=0x012000B4ABB0EF9635994FA680705355892410&id=%2Fsites%2FCAMDCVPTeam%2FShared%20Documents%2FTech%2FCDX%2FMFA%2FCDXICAM%2Dheese%2Epdf&parent=%2Fsites%2FCAMDCVPTeam%2FShared%20Documents%2FTech%2FCDX%2FMFA

Acceptance Criteria

  1. A correct CROMERR activity is created when a user certifies
  2. Documents are properly submitted and signed when the user clicks on "Submit"
esaber76 commented 6 months ago

After I select the Certify button, I'm still taken to the Review & Submit screen where I have to hit the Submit button. I thought from a prior meeting that once a user selects Certify, the submission process should begin and the user would be navigated to the standard Submit screen?

ibarra-michelle commented 6 months ago

Issue: Duplicate Certification sections in the Sign & Submit pop-up.

Description: When I am logged in with my non-org account in the Submit module, I selected the following: under Facilities, I selected Comanche (470); under Configurations, I selected Comanche (470) - 1, and then clicked the "Apply Filter(s)" button. By default, this left the reporting Period with 2024 Q2 selected.

After the filtering is done applying, I select the one Monitoring Plan record was available for me to sign & submit. I clicked the Sign & Submit button and the pop-up window I see displays two identical certification statement sections, even though I only selected one record to submit & certify (see the screenshot).

Image

FYI @yonatan-dp.

yonatan-dp commented 6 months ago

After I select the Certify button, I'm still taken to the Review & Submit screen where I have to hit the Submit button. I thought from a prior meeting that once a user selects Certify, the submission process should begin and the user would be navigated to the standard Submit screen?

This is being implemented through #5830.

ibarra-michelle commented 6 months ago

Issue: Duplicate Certification sections in the Sign & Submit pop-up.

@yonatan-dp and @esaber76, here's a update:

Recreating the new issue: I am logged in as an Org User and have a successful export, import, evaluation experience testing ORIS 470 Location 1 (Comanche), then complete the sign & submit workflow:

  1. In ECMPS dev, when I'm prompted to review 2 cert statements, I get two different certification statements (not duplicate statements): the 1st cert statement does not reference MATS and the 2nd cert statement does reference MATS. The submission is successfully uploaded to the host, and I can confirm the CDX test Submission history only provides the Document set (html and XML) for the Monitoring Plan record, and I do not receive a Document Set (html and xml) for the Certification Statement, (submission id: _67ce513d-6df1-4b8f-b93e-3b874793ad34). CDX test provides 2 Documents sets (1st doc set is for the MP record and the 2nd doc set for the Certification statements).

ECMPS dev Cert Statements screenshot Image

CDX dev > Submission History > Document set screenshot Image

  1. In ECMPS test, I get two certification statements AND they are different statements (not duplicate): the 1st cert statement does not reference MATS and the 2nd cert statement does reference MATS. The submission is successfully uploaded to the host, and I can confirm the CDX test Submission history provides 2 Document sets: the 1st Document set (html and XML) is for the Certification Statements and the 2nd Document set (html and XML) is for Monitoring Plan record (submission id: _9f098e66-2d69-4cd0-b089-7fc947945032).

ECMPS test Cert Statements screenshot Image

CDX test > Submission History >Document Set screenshot Image

maheese commented 6 months ago

After I select the Certify button, I'm still taken to the Review & Submit screen where I have to hit the Submit button. I thought from a prior meeting that once a user selects Certify, the submission process should begin and the user would be navigated to the standard Submit screen?

This is being implemented through #5830.

To add to Michelle's issue, I submitted both a Monitoring Plan and Emissions file and only see the emissions file in the CDX Submission History. Everything else indicates that the submission was successful including the submissions confirmation email which indicates both files were submitted.

CDX Submission History Image

Submission Confirmation Image

ibarra-michelle commented 6 months ago

After I select the Certify button, I'm still taken to the Review & Submit screen where I have to hit the Submit button. I thought from a prior meeting that once a user selects Certify, the submission process should begin and the user would be navigated to the standard Submit screen?

This is being implemented through #5830.

To add to Michelle's issue, I submitted both a Monitoring Plan and Emissions file and only see the emissions file in the CDX Submission History. Everything else indicates that the submission was successful including the submissions confirmation email which indicates both files were submitted.

Additional testing information using a non-organizational account: I also tested the Sign & Submit workflow using my non-organization account and still experienced the same issue in CDX Dev, where I only received the 1st Document Set (html and XML) of the MP record and I did not receive the 2nd Document Set (html and XML) of the Certification Statements (submission id: _8013009b-70ad-4492-9c42-336636175cf1)

Image

ibarra-michelle commented 6 months ago

@yonatan-dp and @esaber76, here's a update:

  • Disregard the duplicate certification statements. I did identify a new issue.
  • New Issue: The CDX Dev Submission History only displays one Document Set (details below). Please comment on whether a new ticket will track the Document Set issues or if the Document Set issue will be tracked in this ticket, thank you.

I can confirm that after you reenabled the process to submit, two of my ECMPS dev MATS sign & submit submissions from this morning were sent to CDX dev. Now, I have 2 document sets associated with each of the submissions in my CDX dev Submissions History (as expected). Lastly, the pdf file is still remains corrupted.

For reference, the submission ids are below:

  1. _e8ad1222-139a-4877-a70f-fc45e098aa6f created 05/24/2024 10:04:51
  2. _2152d7c9-ecef-4900-99ec-26b83ff48757 created 05/24/2024 09:52:59

Image

lgiannini1 commented 5 months ago

Verified with non-EPA account on dev. Was able to submit MP and QA files for ORIS 147, unit K-7. Submission occurred after clicking "Certify" button, and CDX Submission History has documents set for MP, QA, and Certification Statements

ntknguyen commented 5 months ago

Received certification error when trying to submit Greene County CT10 Monitoring Plan.

Image

esaber76 commented 5 months ago

I'm receiving this error trying to submit in the test environment (after selecting Certify).

image

yonatan-dp commented 5 months ago

@esaber76 , is this in dev or test? If in test, I am working with the ICAM team to investigate the issue

esaber76 commented 5 months ago

@yonatan-dp - in test. I'm looking at a different ticket, but just wanted to document the issue.

ibarra-michelle commented 4 months ago

Verified in test for ORIS 470 Location 1 when submitting a Monitoring Plan. The Submit pop-up has:

The MP and Certification statement documents are uploaded into CDX:

Image