Update MP schema: numberOfTraversePointsWAF

US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications

MIT License

0 stars 0 forks source link

Update MP schema: numberOfTraversePointsWAF #6329

Open annalbrecht opened 3 months ago

annalbrecht commented 3 months ago

In the MP schema, numberOfTraversePointsWaf needs to be updated to:

numberOfTraversePointsWAF

Acceptance tests:

Review of the JSON schema file shows the updated JSON element
A file using the new JSON element name is able to be imported successfully
Upon export, the exported file shows the element with the updated name
Verify that the "lastUpdated" date field in the schema document is updated.

usmanahmederg commented 3 months ago

This work has been done in https://github.com/US-EPA-CAMD/easey-ui/issues/6327

mxtomoto1 commented 2 months ago

The MP JSON schema seems to have the correct capitalization for all instances of "numberOfTraversePointsWAF", but the exported JSON for a given MP with created WAF data (tested on ORIS 298, LIM 1) showed the improper capitalization scheme.

mxtomoto1 commented 2 months ago

The MP JSON schema has the correct capitalization for all instances of "numberOfTraversePointsWAF", and an exported JSON for a given MP with created WAF data (tested on ORIS 298, LIM 1) also shows the correct capitalization scheme.

"numberOfTraversePointsWAF" field value does not save properly for:

importing JSON with value
creating / editing Rectangular Duct WAF data in UI.

mark-hayward-erg commented 2 months ago

@usmanahmederg please look into the latest issues reported by @mxtomoto1 as soon as possible.

mxtomoto1 commented 2 months ago

The MP JSON schema has the correct capitalization for all instances of "numberOfTraversePointsWAF", and MP JSON scheme reflects correct "Last Updated" date. An exported JSON for a given MP with created WAF data (tested on ORIS 298, LIM 1) also shows the correct capitalization scheme with the correct value. Number of Traverse Points WAF value saves properly when created / edited in UI or is imported from a JSON into the UI.

ntknguyen commented 2 months ago

Tested on Mill Creek 1,2,CS12. Verified adding new the Rectangular Duct WAF record, saving and exporting data.