US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Fix issue with validators when `each` is true #6386

Open maxdiebold-erg opened 2 months ago

maxdiebold-erg commented 2 months ago

Several of the DTO validators are throwing errors for parameters where multiple values are accepted. The required change has already been made in the 11.x branch of easey-common (see https://github.com/US-EPA-CAMD/easey-common/pull/161). This should be propagated to the master branch, and ECMPS 2.0 repositories should be updated to use the latest version.

Acceptance Tests

Endpoints that accept multiple values for a parameter with a decorator that uses the DbLookupValidator under the hood should return a success response. Some endpoints to test include:

lgiannini1 commented 2 months ago

Verified on dev swagger page using endpoints listed in acceptance tests. Received success responses when selecting multiple values for parameters stateCode, controlTechnologies, unitType, unitFuelType, programCodeInfo, and accountType

ibarra-michelle commented 1 month ago

Verified in test swagger page (200 HTTP response) for the following endpoints:

  1. https://api.epa.gov/easey/dev/emissions-mgmt/emissions/apportioned/hourly/by-state?stateCode=AL&beginDate=2023-01-01&endDate=2023-12-31&page=1&perPage=1
  2. https://api.epa.gov/easey/dev/emissions-mgmt/emissions/apportioned/quarterly/nationally?controlTechnologies=Baghouse&year=2023&quarter=1&page=1&perPage=1
  3. https://api.epa.gov/easey/dev/emissions-mgmt/emissions/apportioned/quarterly/nationally?programCodeInfo=ARP&year=2023&quarter=1&page=1&perPage=1
  4. https://api.epa.gov/easey/dev/streaming-services/allowance-holdings?accountType=Compliance%20Assurance%20Surrender%20Account