US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications
MIT License
0 stars 0 forks source link

Retest: Unselected configurations available for evaluation #6434

Open ibarra-michelle opened 1 month ago

ibarra-michelle commented 1 month ago

After selecting one configuration to export and import for evaluation, the evaluation module displays a second or duplicate configuration from the same facility (ORIS), even only one configuration was selected for evaluation.

This bug was observed in the ORIS Config combinations listed below. The timestamp is also between the selected and unselected (or duplicate) configuration.

1.ORIS 2514 Config 40 was selected (some how, config 50 data was also available to be evaluated)
Image

  1. ORIS 628 Config 1 was checked out (some how, config 2 data was also available to be evaluated)
    Image

  2. ORIS 50282 Config PR003, PR004, PR005, CSPR06 was checked out (some how, duplicate records of PR003, PR004, PR005, CSPR06 were made available to evaluate. I reverted to the official record and one of the two MP records were removed. The screenshot displays the remaining record with no configuration associated with it.). Image

annalbrecht commented 4 weeks ago

Blocked by #6425

maxdiebold-erg commented 3 weeks ago

@ibarra-michelle I looked into the issue in the first point, and it appears that both of those units (40 & 50) have been retired, and the associated Monitor Plans should have ended. As I noted previously, the new import process needs to assess all current plans in the workspace, and it determined that those two plans should have ended. I'd guess the same thing is happening in the point number 2, but I will surely double check.

We probably want to add logic to end a USC and monitor plan when a unit is retired.

EDIT: I've confirmed that units 1 & 2 in ORIS 628 have also been retired.

ibarra-michelle commented 3 weeks ago

We probably want to add logic to end a USC and monitor plan when a unit is retired.

Thanks @maxdiebold-erg for summarizing your findings and including the recommended next step. Let's confirm what are the next steps are at the next Standup meeting (e.g., who is writing up the new ticket, initial requirements, do we close this tix #6434, priority, etc.).

FYA - @annalbrecht , @spetros-do , @alangmaid , @maheese , @bryanramirez1 , @j-tafoya

ibarra-michelle commented 3 weeks ago

We probably want to add logic to end a USC and monitor plan when a unit is retired.

From the 10/30/2024 DSU meeting, the team concluded to create 2 new placeholder tickets (requirements needed for both tickets) to address Max's recommendation to to add logic to end a USC and monitor plan when a unit is retired:

  1. The 1st tix (#6437) should address the short-term solution (script) in 2025Q1 that Must be included in the ECMPS.
  2. The 2nd tix (#6438) should address a long-term solution Post ECMPS release (e.g., possibly development of functionality in the Admin view or DS/DP Workspace view).