add PR template validation

US-GHG-Center / veda-config-ghg

Veda config for GHG

https://ghg-demo.netlify.app

Other

3 stars 15 forks source link

add PR template validation #248

Closed stephenkilbourn closed 2 months ago

stephenkilbourn commented 7 months ago

What am I changing and why

I've added a bit of clarification on the PR template and then added a github action to validate that a description other than the text in the PULL_REQUEST_TEMPLATE.md is used.

How to test

This can be seen by creating a PR and not editing the template. Screenshot of that case:

Now that the template is edited, look to see that the test step has passed.

⚠️ Checks

[x ] I have confirmed that updating the veda-ui submodule is needed and only done so if that's the case.

netlify[bot] commented 7 months ago

Deploy Preview for ghg-demo ready!

Name	Link
Latest commit	8790528e253a9d7b0c8284116cab43c0451e25e0
Latest deploy log	https://app.netlify.com/sites/ghg-demo/deploys/6566269a3a911f0008240647
Deploy Preview	https://deploy-preview-248--ghg-demo.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 7 months ago

PR description is too short and seems to not fulfill PR template, please fill in

j08lue commented 2 months ago

I think we still need a better PR template and can then consider adding a checker that people actually use it. Closing for now.