search

US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

add initial playwright suite #250

Closed stephenkilbourn closed 4 months ago

stephenkilbourn commented 7 months ago

This add a Playwright as a possible end to end testing suite. There is a github action that will run the suite on each MR. A developer can also run the tests by the script yarn test:e2e.

The suite will run the tests in three browsers:

After the test run, the action will attach a report as a zip file. That file will have an html report of the test run. In addition, any failed tests from the run will include a trace that includes network calls and screenshots to allow a developer to walk through the test in an attempt to debug the root cause of failure.

netlify[bot] commented 7 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit 05393e1b891657a52158891a1066a83a7e308f4a
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/6578f3ff10b079000844e12a
Deploy Preview https://deploy-preview-250--ghg-demo.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stephenkilbourn commented 7 months ago

@anayeaye - tagging you here, but I'm not sure who else should review. I can walk through the code in a call, as well.

j08lue commented 6 months ago

nb - currently, this PR includes a change to the VEDA UI git submodule version. That change should be removed from the PR, I guess.

j08lue commented 6 months ago

Thanks for moving this forwards, @stephenkilbourn!

Regarding reviews - the Dashboard team (@hanbyul-here, @sandrahoang686) have been looking after the setup of these config repos in the past and would be good to bring in for assessing this.

While I think we could consider merging this Playwright setup for a bit of real-world testing in the coming weeks, I would first like for the team to get an understanding of the consequences in terms of maintenance and development overhead this may cause, before we commit to maintaining this longer-term.

stephenkilbourn commented 6 months ago

nb - currently, this PR includes a change to the VEDA UI git submodule version. That change should be removed from the PR, I guess.

good catch. reverted that in this commit

sandrahoang686 commented 4 months ago

Same comment applies here: https://github.com/NASA-IMPACT/veda-ui/pull/835#issuecomment-1964255232

stephenkilbourn commented 4 months ago

closing to use work in veda-config for use with veda-deploy: https://github.com/NASA-IMPACT/veda-config/pull/363