US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Pass maxzoom as sourceparam for methane gridded dataset #260

Closed hanbyul-here closed 4 months ago

hanbyul-here commented 6 months ago

Why are you creating this Pull Request?

@slesaad I remember we discussed this issue a while ago. I don't know the dataset very well (like what the actual maxzoom is?) but setting the maxzoom on sourceParams level seems to solve the issues for me. Can you confirm?

The overzoomed data looks blurry. We can work around this by setting up raster-resampling to nearest (currently, it is default which is linear. but I want to confirm if setting maxzoom for sourceParams resolve the issue,)

Preview: https://deploy-preview-260--ghg-demo.netlify.app/data-catalog/epa-ch4emission-yeargrid-v2express/explore?projection=equirectangular%7C%7C&basemapid=light&datetime=2020-01-01T00%3A00%3A00.000Z&position=-95.4236%7C40.4484%7C8.39

netlify[bot] commented 6 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit df4cc3ef3fde31c38d1cd13b68391cee7d542149
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/659c5fc32aaf2e0008ced873
Deploy Preview https://deploy-preview-260--ghg-demo.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slesaad commented 6 months ago

@hanbyul-here does look like it solves the problem, but why is everything so blurry when zoomed in? 🤔

hanbyul-here commented 6 months ago

@slesaad We are using Mapbox default interpolationmethod for over zoomed data - raster-resampling: linear We can change the default to raster-resampling: nearest which will return less blurry result.

hanbyul-here commented 5 months ago

I also checked in with @vincentsarago that the problem could come from the original data (the overviews where created using weird resampling algorithm or there is an issue with the nodata value)

hanbyul-here commented 4 months ago

Closing as it was data problem.