search

US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Adding custom javascript tag as a fix for implementing DAP script block for GHG #292

Closed amarouane-ABDELHAK closed 7 months ago

amarouane-ABDELHAK commented 7 months ago

Why are you creating this Pull Request?

This PR is created in response to an email stating "We need immediate assistance from you and your web team to complete NASA’s required response to OMB M-23-22 by March 13, 2024. This memo directs agencies to ensure that GSA’s Digital Analytics Program (DAP) tracking code is installed on all public-facing sites to enable reporting of web traffic metrics.

netlify[bot] commented 7 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit d65d3d201f393f97031ff55c8a3f5dbd79cbfbb4
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/65cf928a4f19a100081ba168
Deploy Preview https://deploy-preview-292--ghg-demo.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hanbyul-here commented 7 months ago

How immediate does this need to go out? Pointing a branch in UI is a practice that I would like us to avoid.

amarouane-ABDELHAK commented 7 months ago

How immediate does this need to go out? Pointing a branch in UI is a practice that I would like us to avoid.

The sooner the better but COB on this is March 13, 2024.

I agree pointing to a branch/commit is not a good practice and we should avoid it.

hanbyul-here commented 7 months ago

Then let's close this and work on this ticket: https://github.com/US-GHG-Center/veda-config-ghg/issues/298 !