search

US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Add dataset metadata for new E&A to all relevant datasets #317

Closed j08lue closed 3 months ago

j08lue commented 4 months ago

Closes #303

  1. Add infoDescription blocks for each dataset
  2. Add info blocks for each layer
  3. Add media blocks for each layer

Structured info (info description)

Structured info (info blocks for each layer)

Thumbnails

netlify[bot] commented 4 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit 12b74c715e3c8e7f09c0812bd0e7fd693c59f72f
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/660d5a2f382fe400088d4112
Deploy Preview https://deploy-preview-317--ghg-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

faustoperez commented 4 months ago

I finished adding the layer thumbnails @j08lue . I didn't update the NOAA + methane ones as they don't load on E&A. Could revisit if needed 👍

j08lue commented 4 months ago

I didn't update the NOAA + methane ones as they don't load on E&A

Yes, we do not need layer thumbnails for those for now. We can add them later, if need arises.

We will need the structured data, though, please, @siddharth0248, so we can use it in new designs of the Dataset cards in the Data Catalog (https://github.com/US-GHG-Center/ghgc-architecture/issues/133).

siddharth0248 commented 3 months ago

@faustoperez @j08lue I have updated the mdx for all the required files and updated the checkbox list

j08lue commented 3 months ago

I'd like to take a look once everything is in the E&A environment

I merged the latest changes here into the preview at https://github.com/US-GHG-Center/veda-config-ghg/pull/319 - please check it out here: https://deploy-preview-319--ghg-demo.netlify.app/exploration

Jeanne-le-Roux commented 3 months ago

@j08lue When you click on an info button for a dataset layer, I think it would be more useful to see the temporal resolution on the top line as opposed to the latency. (e.g. in this example "monthly" rather than "approximately 2 years" - what do you think? Was there a justification for choosing latency to go in this position?

image
j08lue commented 3 months ago

I think it would be more useful to see the temporal resolution on the top line as opposed to the latency

You are right. Sorry that I did not catch that earlier myself. This goes for the dataset card as well as the info page.

Let us please replace this in all the files here - latency -> temporalResolution - and I will make sure it gets updated in VEDA UI as well

j08lue commented 3 months ago

Let us please replace this in all the files here

Done in the above commit. https://github.com/US-GHG-Center/veda-config-ghg/pull/317/commits/d54faf2b28710cefffb3c197697b32d6fb759dab

j08lue commented 3 months ago

I made the changes we discussed, @Jeanne-le-Roux and @siddharth0248:

  1. Make the list of short info source, spatialExtent, temporalResolution, unit
  2. Replace NASA,NOAA with NASA / NOAA

Can you give it one more look in this preview, please, @Jeanne-le-Roux, and confirm that it is ready to go out (when we launch E&A)?

https://deploy-preview-319--ghg-demo.netlify.app/

Jeanne-le-Roux commented 3 months ago

@j08lue I think this looks good. One more thing - right now the unique layer descriptions are only displayed when you are presented with layers to select, but when you click on the info button for a layer in the explore environment that short layer description doesn't seem to be there. This is something that we need to make sure is visible somewhere. layer_descr layer_info

j08lue commented 3 months ago

Thanks, @Jeanne-le-Roux, I'll merge this PR then, to avoid more merge conflicts. Since the changes are backwards-compatible, there should be no issue in merging them already now, before the release of E&A.

I ticketed your suggestion for adding the layer description to the info modal - should be a quick fix.