search

US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Add config to open external links in a new tab #326

Closed sandesh-sp closed 2 months ago

sandesh-sp commented 3 months ago

Add config to open external links in a new browser tab

Closes https://github.com/US-GHG-Center/veda-config-ghg/issues/315

netlify[bot] commented 3 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit 9718800010514e904562ba65160cdcfb300b40d1
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/662a3c7b08a8b8000804d383
Deploy Preview https://deploy-preview-326--ghg-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

j08lue commented 3 months ago

Which commit or version are you updating VEDA UI to, @sandesh-sp, and why?

I see the change in VEDA UI to use this setting has not been merged yet.

sandesh-sp commented 3 months ago

@j08lue I might be unaware of the process. Should the changes on veda-ui be merged before I send a pull request here?

j08lue commented 3 months ago

Should the changes on veda-ui be merged before I send a pull request here?

Yes, we have not been requiring versioned releases on VEDA UI for instances to use, lately, but it should at least be merged to main on VEDA UI and ideally also version-tagged.

Btw, once we have turned VEDA UI into a library, hopefully later this year, you will have to use a packaged release.

j08lue commented 3 months ago

To avoid the merge conflicts for VEDA UI upgrade, perhaps make this PR just about the content changes and merge it only when VEDA UI has been updated (elsewhere).

slesaad commented 3 months ago

@j08lue that's the plan. for now, we just wanted to test the feature with this PR. We'll wait for the next veda-ui release to merge this PR.

j08lue commented 3 months ago

Ah, sorry I broke it then. Back to main for now.

j08lue commented 2 months ago

How to test this:

See that the link to the IPCC-related website in the intro story

See that links in the footer still work as expected.