Closed sandrahoang686 closed 2 months ago
Name | Link |
---|---|
Latest commit | ebd81fecb0f7010430cec5262bf0038ebd90c9ee |
Latest deploy log | https://app.netlify.com/sites/ghg-demo/deploys/6633e726be1c7400089e423a |
Deploy Preview | https://deploy-preview-362--ghg-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@j08lue @sandrahoang686 Jerika and I both just looked at the netlify preview and the video size was actually just fine! No need to change size. Thank you!!
@j08lue do you mean the Data Insights page instead? (If we add to Data Insights page, this would be a 2 piece PR where I would have to update veda-ui as well to look at overrides) https://github.com/US-GHG-Center/ghgc-architecture/issues/198#issuecomment-2090868486
And I read that this mockup is a temp solution until the modal is done? from here: https://github.com/US-GHG-Center/ghgc-architecture/issues/198#issuecomment-2090926527 and from here: https://github.com/US-GHG-Center/ghgc-architecture/issues/198#issuecomment-2090942817 but is that changing?
@sandrahoang686 We decided this afternoon that it would be ideal to have both the button with modal on the homepage as well as the video embed on the Intro to GHG Center Data Insight. This would give 2 opportunities for site users to encounter the video.
This is the story where the video should be, please: https://github.com/US-GHG-Center/veda-config-ghg/blob/develop/stories/intro-us-ghg-center.stories.mdx
Why are you creating this Pull Request?
Closes https://github.com/US-GHG-Center/ghgc-architecture/issues/198
This creates a video modal override component so we can display the GHGC Demo Video as part of the landing page
@j08lue @faustoperez I used our DS library's modal component to be quick so I didn't have to create the modal styles from scratch and the modal styles (like background opacity) matches the rest of where ever we use the modal (google-form). But because of this the close button is closer to the video content instead of what was outlined in figma. This is because of the built in modal header in our DS Modal component. Will this be okay?