search

US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Add video to Data Insights stories/into-us-ghg-center #364

Closed sandrahoang686 closed 2 months ago

sandrahoang686 commented 2 months ago

Why are you creating this Pull Request?

Closes https://github.com/US-GHG-Center/ghgc-architecture/issues/198

netlify[bot] commented 2 months ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit b4ee6671e73eb438e4bd7ba8db10befd9ff4d9ec
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/663421a78355bb0008e08d2f
Deploy Preview https://deploy-preview-364--ghg-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

faustoperez commented 2 months ago

Looking good @sandrahoang686 ! One minor thing, can we make the Learn more button use a secondary style? The two buttons are clashing a bit.

From this:

image

To this:

image

Thank you!

j08lue commented 2 months ago

I merged quickly yesterday before you had a chance to review, @faustoperez, so this could go right into ongoing stakeholder review.

Will otherwise wait for your sign-off. 🙏

faustoperez commented 2 months ago

I merged quickly yesterday before you had a chance to review, @faustoperez, so this could go right into ongoing stakeholder review.

Super fast work everybody 🚀 , I have just a this minor comment on the button style, thanks for creating a separate ticket 🙏

sandrahoang686 commented 2 months ago

@faustoperez my apologies, I was trying to push this out quick and I guess I didn't notice that in the figma! Thanks for pointing this out 🙏🏼